[MNG-8214] Improve model velocity template to support subclasses #1660
Conversation
|
I don't really see what's your use case for that ? We already have inheritance such as |
|
This is not about inheritance within MDO models but inheritance of classes generated from MDO, like for https://github.com/apache/maven-plugin-tools/blob/9332b09acc08d2e063f12a8158a57ca8ec56fadd/maven-plugin-tools-api/src/main/java/org/apache/maven/tools/plugin/ExtendedMojoDescriptor.java#L31. This is currently not possible due to the restricted visibility of the constructors and the lack of a constructor taking a builder as argument. |
Fair point. However the use case of ExtendedMojoDescriptor is definitely a bad one. Those were needed because the models did not really evolved, but we allowed small additions without properly versioning them, and then rely on such hacks. |
kwin
force-pushed
the
feature/MNG-8214-improved-builder-in-velocity
branch
from
d62176b to
93079ea
Compare
I only partially agree, extending the MDO for this case is not useful as the additional attribute really only is useful in the plugin-tools context and therefore this class is only used internally. Although one could probably do things differently, the effort when not extending the original Maven classes is considerably higher (as one somehow needs to establish the connection between the raw Maven object and the extended plugin tools one). |
kwin
force-pushed
the
feature/MNG-8214-improved-builder-in-velocity
branch
from
93079ea to
c994b63
Compare
kwin
force-pushed
the
feature/MNG-8214-improved-builder-in-velocity
branch
4 times, most recently
from
ae77de5 to
a0bde50
Compare
Make the constructors protected and take the Builder as argument
kwin
force-pushed
the
feature/MNG-8214-improved-builder-in-velocity
branch
from
a0bde50 to
402c8c2
Compare
kwin
force-pushed
the
feature/MNG-8214-improved-builder-in-velocity
branch
from
8bc5d20 to
8ce4cde
Compare
This makes the constructor protected and takes the Builder as argument
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MNG-XXX] SUMMARY,where you replace
MNG-XXXandSUMMARYwith the appropriate JIRA issue.[MNG-XXX] SUMMARY.Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message.
mvn clean verifyto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.